Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Bump Terraform provider version and configure bucket timeout #61

Merged
merged 4 commits into from
May 6, 2022

Conversation

turkenh
Copy link
Collaborator

@turkenh turkenh commented Apr 21, 2022

Description of your changes

This PR fixes bucket timeout issue by;

  • Bumping GCP Terraform Provider version to the latest (to get configurable timeout fix)
  • Configuring read timeout for Bucket resource.

Depends on crossplane/terrajet#276

Fixes #12

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Create/Delete a bucket using the example.

@turkenh turkenh requested review from ezgidemirel and muvaf April 21, 2022 14:25
@turkenh turkenh changed the title Bump terraform versions and configure bucket timeout Bump Terraform provider version and configure bucket timeout Apr 21, 2022
Copy link
Collaborator

@ezgidemirel ezgidemirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New fields coming from version bump are all optional. I don't see any breaking change. LGTM!

turkenh added 4 commits May 6, 2022 11:24
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Fixes crossplane-contrib#12

Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
@turkenh turkenh force-pushed the bump-terraform-versions branch from 51a50aa to d1827ff Compare May 6, 2022 08:28
@turkenh turkenh merged commit 1893f0e into crossplane-contrib:main May 6, 2022
@turkenh turkenh deleted the bump-terraform-versions branch May 6, 2022 08:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bucket resource fails
2 participants